Crazy Tronners :: View topic - player msg hack is code-redundant and can't handle clientnum

epsy · Posted: Wed Jul 11, 2007 6:50 pm

and here is the fix Smile

Code:

static void PlayerConsoleOut_conf(std::istream &s)
{
int receiver = se_ReadUser(s);

tString msg_core;
msg_core.ReadLine( s, true );

tColoredString toServer;
se_AppendChat( toServer, msg_core );
toServer << '\n';

// log locally
sn_ConsoleOut(toServer,0);

// send to receiver
sn_ConsoleOut(toServer, receiver);
return;
}

static tConfItemFunc PlayerConsoleOut_c("PLAYER_MESSAGE",&PlayerConsoleOut_conf);

so this version of player_message can handle client numbers and doesn't repeat the code to get the client num a given player has

this version obeys to the same rules as kick, ban, kill, silence, voice, allow_team_change_player, disallow_team_change_player like wrtl says Razz

btw, he also said that

wrtlprnft, in #armagetron wrote:

with your version ed's scripts will screw up if you have a player named �1�, but with the player ID 7

which is true

syllabear · Posted: Sun Jul 22, 2007 12:09 pm

thats really good, but u dont usually get players named 1/2/3

if u do they are usually noobs, who u dont wanna message

_________________
Ex- [CT]Syllabear
Ex- [FE]Syllabear (leader)

A key that opens many doors is a master key. A lock that is opened by many keys is a shit lock

P4 · Posted: Sun Jul 22, 2007 12:37 pm

it also applies to kicking, banning and all things related to pointing a player

_________________
P4

epsy · Posted: Sun Jul 22, 2007 11:37 pm

that's for better integration...except it implies some rewrite of the ctwf scripts...that's why voodoo could not accept it(d'uh we lazy french ppl Very Happy

)